Skip to content

[Doc] Change PUT to POST _search in semantic-text.md example #134256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PeteGillinElastic merged 2 commits into from
Sep 9, 2025
Merged

[Doc] Change PUT to POST _search in semantic-text.md example #134256

PeteGillinElastic merged 2 commits into from
Sep 9, 2025

Conversation

@daixque
Copy link
Contributor

@daixque daixque commented Sep 6, 2025

Current example of a semantic highlighter query uses a PUT index API, but it should be a search API.

@daixque
Change PUT to POST _search in semantic-text.md example
6986880 
Current example of a semantic highlighter query uses a PUT index API, but it should be a search API.
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Sep 6, 2025

@daixque please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Sep 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2025 •
edited
Loading

🔍 Preview links for changed docs

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2025

ℹ️ Important: Docs version tagging

👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version.

We use applies_to tags to mark version-specific features and changes.

Expand for a quick overview

When to use applies_to tags:

✅ At the page level to indicate which products/deployments the content applies to (mandatory)
✅ When features change state (e.g. preview, ga) in a specific version
✅ When availability differs across deployments and environments

What NOT to do:

❌ Don't remove or replace information that applies to an older version
❌ Don't add new information that applies to a specific version without an applies_to tag
❌ Don't forget that applies_to tags can be used at the page, section, and inline level

🤔 Need help?

@PeteGillinElastic PeteGillinElastic added >docs General docs changes and removed external-contributor Pull request authored by a developer outside the Elasticsearch team labels Sep 9, 2025
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team and removed needs:triage Requires assignment of a team area label labels Sep 9, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Sep 9, 2025

Pinging @elastic/core-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Sep 9, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Sep 9, 2025

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@PeteGillinElastic PeteGillinElastic self-assigned this Sep 9, 2025
PeteGillinElastic
PeteGillinElastic approved these changes Sep 9, 2025
View reviewed changes
Copy link
Member

@PeteGillinElastic PeteGillinElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. This looks like a pretty straight-forward copy-and-paste error, so I'm happy to approve the fix.

@PeteGillinElastic PeteGillinElastic enabled auto-merge (squash) September 9, 2025 10:39
@PeteGillinElastic PeteGillinElastic merged commit 18037bb into main Sep 9, 2025
12 checks passed
@PeteGillinElastic PeteGillinElastic deleted the fix_semantic_highlighter_endpoint_typo branch September 9, 2025 10:48
rjernst pushed a commit to rjernst/elasticsearch that referenced this pull request Sep 9, 2025
@daixque @rjernst
Change PUT to POST _search in semantic-text.md example (elastic#134256)
c33dedc 
Current example of a semantic highlighter query uses a PUT index API, but it should be a search API.
Kubik42 pushed a commit to Kubik42/elasticsearch that referenced this pull request Sep 9, 2025
@daixque @Kubik42
Change PUT to POST _search in semantic-text.md example (elastic#134256)
dc61ca6 
Current example of a semantic highlighter query uses a PUT index API, but it should be a search API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PeteGillinElastic PeteGillinElastic PeteGillinElastic approved these changes

Assignees

@PeteGillinElastic PeteGillinElastic

Labels

>docs General docs changes :Search Relevance/Vectors Vector search Team:Docs Meta label for docs team Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@daixque @elasticsearchmachine @PeteGillinElastic